contrib/database/sql: fix support for drivers using deprecated interfaces #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces Some drivers like the go-mssqldb driver do not implement newer database/sql interfaces like Queryer/QueryerContext. Previously the code would erroneously assume drivers that did not implement a QueryerContext interface would implement the Queryer interface. This lead to panics like in issue #1043.
knusbaum
requested changes
Feb 28, 2022
| "github.com/go-sql-driver/mysql" | ||
| "github.com/jackc/pgx/v4/stdlib" | ||
| _ "github.com/lib/pq" | ||
| "github.com/stretchr/testify/assert" | ||
| mysqlgorm "gorm.io/driver/mysql" | ||
| "gorm.io/driver/postgres" | ||
| "gorm.io/driver/sqlserver" |
There was a problem hiding this comment.
Found the issue with the gorm dependency.
This dep pulls in a newer version of gorm.
We need to pin this to v1.3.0 which shouldn't cause a newer gorm to be pulled.
https://github.com/go-gorm/sqlserver/blob/v1.3.0/go.mod
knusbaum
reviewed
Feb 28, 2022
ajgajg1134
force-pushed
the
ajgajg1134/databaseRefactor
branch
from
504ee4a
to
9695935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some drivers like the go-mssqldb driver do not implement newer database/sql interfaces like Queryer/QueryerContext. Previously the code would erroneously assume drivers that did not implement a QueryerContext interface would implement the Queryer interface. This lead to panics like in issue #1043.
This PR fixes #1043 and is an improved version (based on PR comments) of PR #1163