Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/gin-gonic: add AppSec support to gin framework #1165

Merged
merged 11 commits into from Feb 16, 2022
Merged

contrib/gin-gonic: add AppSec support to gin framework #1165

merged 11 commits into from Feb 16, 2022

Conversation

Hellzy
Copy link
Contributor

@Hellzy Hellzy commented Feb 9, 2022

  • Add call to useAppsec in gintrace.go when AppSec is enabled
  • Add testing of AppSec functionalities in gintrace_test.go
  • Add appsec.go file that holds AppSec handling for gin

@Hellzy Hellzy requested a review from a team as a code owner February 9, 2022 15:13
@Hellzy Hellzy requested a review from a team February 9, 2022 15:13
@Hellzy Hellzy self-assigned this Feb 9, 2022
@Hellzy Hellzy added the appsec label Feb 9, 2022
@Hellzy Hellzy added this to the 1.37.0 milestone Feb 9, 2022
@Hellzy Hellzy force-pushed the francois.mazeau/appsec-gin branch 2 times, most recently from ea14b5b to 8e436fe Compare February 9, 2022 16:05
Julio-Guerra
Julio-Guerra requested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@Julio-Guerra Julio-Guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done - here a some important suggestions.

contrib/gin-gonic/gin/gintrace.go Outdated Show resolved Hide resolved
contrib/gin-gonic/gin/appsec.go Outdated Show resolved Hide resolved
contrib/gin-gonic/gin/gintrace_test.go Outdated Show resolved Hide resolved
Julio-Guerra
Julio-Guerra requested changes Feb 10, 2022
View reviewed changes
contrib/gin-gonic/gin/gintrace.go Show resolved Hide resolved
contrib/gin-gonic/gin/gintrace_test.go Show resolved Hide resolved
contrib/gin-gonic/gin/gintrace_test.go Outdated Show resolved Hide resolved
Julio-Guerra
Julio-Guerra previously approved these changes Feb 10, 2022
View reviewed changes
contrib/gin-gonic/gin/gintrace.go Outdated Show resolved Hide resolved
@Hellzy
Copy link
Contributor Author

Hellzy commented Feb 10, 2022

@knusbaum could you take a look at this when possible? I tried to keep the alterations to gintrace.go to a minimum

ajgajg1134
ajgajg1134 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@Hellzy Hellzy merged commit 0d15cb7 into v1 Feb 16, 2022
@Hellzy Hellzy deleted the francois.mazeau/appsec-gin branch February 16, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julio-Guerra Julio-Guerra Julio-Guerra approved these changes

@knusbaum knusbaum Awaiting requested review from knusbaum

@ajgajg1134 ajgajg1134 Awaiting requested review from ajgajg1134

Assignees

@Hellzy Hellzy

Labels
appsec
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hellzy @Julio-Guerra @ajgajg1134