New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/gin-gonic: add AppSec support to gin framework #1165
Conversation
9a42fa1
to
24300ff
Compare
ea14b5b
to
8e436fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done - here a some important suggestions.
@knusbaum could you take a look at this when possible? I tried to keep the alterations to |
9d22f81
to
35ce32e
Compare
Co-authored-by: Julio Guerra <julio@datadog.com>
Co-authored-by: Julio Guerra <julio@datadog.com>
35ce32e
to
ebc8f85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
useAppsec
in gintrace.go when AppSec is enabled