Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: fix a bug with the x-datadog-tags header parser #1155

Merged
merged 2 commits into from Feb 9, 2022

Conversation

Barbayar
Copy link
Contributor

Context

After talked to the other integration teams, we updated x-datadog-tags format a little bit. Before, = wasn't allowed in the tag value. Now, = is allowed in the tag value. Which means, the following value is valid x-datadog-tags value.

tag1=value1,tag2=val=ue2===,tag3=value3

After the parser parsed the above value, we expect the following dictionary.

{
    "tag1": "value1",
    "tag2": "val=ue2===",
    "tag3": "value3"
}

@Barbayar Barbayar requested a review from a team January 31, 2022 22:14
@gbbr gbbr added this to the 1.37.0 milestone Feb 1, 2022
@gbbr gbbr changed the title ddtrace/tracer: Updated x-datadog-tags parser. ddtrace/tracer: fix a bug with the x-datadog-tags header parser Feb 1, 2022
@gbbr gbbr added the bug unintended behavior that has to be fixed label Feb 1, 2022
@Julio-Guerra Julio-Guerra merged commit 4bb4d45 into v1 Feb 9, 2022
@Julio-Guerra Julio-Guerra deleted the barbayar.dashzeveg/x-datadog-tags-decoder branch February 9, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants