From 3eded75cf867baa23fa76f28ba709d56b22ef904 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Mazeau?= Date: Wed, 22 Jun 2022 17:25:10 +0200 Subject: [PATCH] contrib/internal/httptrace: add TODO to track span start options refactoring --- contrib/internal/httptrace/httptrace.go | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/internal/httptrace/httptrace.go b/contrib/internal/httptrace/httptrace.go index 76ff95ec55..18bcd7c84a 100644 --- a/contrib/internal/httptrace/httptrace.go +++ b/contrib/internal/httptrace/httptrace.go @@ -46,6 +46,7 @@ var ( // http.useragent). Any further span start option can be added with opts. func StartRequestSpan(r *http.Request, opts ...ddtrace.StartSpanOption) (tracer.Span, context.Context) { // Append our span options before the given ones so that the caller can "overwrite" them. + // TODO(): rework span start option handling (https://github.com/DataDog/dd-trace-go/issues/1352) opts = append([]ddtrace.StartSpanOption{ tracer.SpanType(ext.SpanTypeWeb), tracer.Tag(ext.HTTPMethod, r.Method),