Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win pipes] Defer connection establishment to first write #190

Merged
merged 2 commits into from Mar 15, 2021

Conversation

olivielpeau
Copy link
Member

This allows the client creation call (New) with a windows named pipe
target address to be successful even if the Agent hasn't created the
named pipe yet.

This new behavior is consistent with the UDS writer.

I haven't tested the change on Windows, relying on CI to catch any regression on Windows.

Allows the client creation call (`New`) call with a windows named pipe
target address to be successful even if the Agent hasn't created the
named pipe yet. This new behavior is consistent with the UDS writer.
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Olivier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants