Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statsd: ensure Windows Pipe writer tries to reconnect when losing connection #185

Merged
merged 4 commits into from Feb 11, 2021
Merged

statsd: ensure Windows Pipe writer tries to reconnect when losing connection #185

merged 4 commits into from Feb 11, 2021

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Feb 11, 2021 •
edited

This changes ensures that the Windows Pipe statsdWriter attempts
reconnecting after losing a connection.

@gbbr
statsd: ensure Windows Pipe writer tries to reconnect when losing
f464b5c 
connection

This changes ensures that the Windows Pipe statsdWriter attempts
reconnecting after losing a connection.
@gbbr gbbr changed the title statsd: ensure Windows Pipe writer tries to reconnect when losing statsd: ensure Windows Pipe writer tries to reconnect when losing connection Feb 11, 2021
ogaca-dd
ogaca-dd reviewed Feb 11, 2021
View reviewed changes
Copy link

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, just a few comments.

statsd/pipe_windows.go Show resolved Hide resolved
statsd/pipe_windows.go Show resolved Hide resolved
statsd/pipe_windows_test.go Show resolved Hide resolved
statsd/pipe_windows_test.go Show resolved Hide resolved
gbbr
gbbr commented Feb 11, 2021
View reviewed changes
Copy link
Contributor Author

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Olivier! Let's keep it consistent with the UDS implementation, as discussed on Slack.

statsd/pipe_windows.go Show resolved Hide resolved
@gbbr gbbr merged commit 79f7121 into master Feb 11, 2021
@gbbr gbbr deleted the gbbr/reconnect-pipe branch February 11, 2021 13:47
gbbr added a commit that referenced this pull request Feb 11, 2021
@gbbr
Add #185
6cd01d1
This was referenced Mar 17, 2021
Closed
Closed
Closed
Merged
Closed
@gbbr gbbr mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogaca-dd ogaca-dd ogaca-dd left review comments

@hush-hush hush-hush hush-hush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gbbr @hush-hush @ogaca-dd