statsd: add support for Windows Pipes #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for Windows Named Pipes. They may be used when this option is [enabled in the Datadog Agent](DataDog/datadog-agent#6830).
hush-hush
requested changes
Feb 9, 2021
Co-authored-by: Lucas Pimentel-Ordyna <lucas.pimentel@datadoghq.com>
hush-hush
approved these changes
Feb 10, 2021
ogaca-dd
reviewed
Feb 10, 2021
| } | ||
|
|
||
| func newWindowsPipeWriter(pipepath string) (*pipeWriter, error) { | ||
| conn, err := winio.DialPipe(pipepath, nil) |
There was a problem hiding this comment.
What happens if the connexion is temporary lost between the client and the server?
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for Windows Named Pipes. They may be used when
this option is enabled in the Datadog Agent.