Fix worker random race condition #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Not a blocker, I'm just curious: what's the impact of this change on the benchmark of the original PR: #178 ?
hush-hush
force-pushed
the
maxime/fix-random-race
branch
from
92884bd
to
7584327
Compare
truthbk
approved these changes
Jan 27, 2021
| @@ -71,9 +73,15 @@ func (w *worker) processMetric(m metric) error { | |||
| } | |||
|
|
|||
| func (w *worker) shouldSample(rate float64) bool { | |||
| // rand.NewSource is not thread safe. | |||
There was a problem hiding this comment.
Nit: for clarity, I suggest:
Suggested change
| // rand.NewSource is not thread safe. | |
| // sources created by rand.NewSource() (ie. w.random) are not thread safe. |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand.NewSourceis not thread safe. Each worker needs its own random and random-lock.