Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devMode telemetry naming and taging #175

Merged
merged 1 commit into from Jan 6, 2021

Conversation

hush-hush
Copy link
Member

This makes the telemetry for the beta client aggregation easier to graph and use

Copy link

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

statsd/telemetry_test.go Outdated Show resolved Hide resolved
statsd/telemetry_test.go Outdated Show resolved Hide resolved
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much ready to go! Just a comment made in the previous review that I think should be addressed.

statsd/telemetry_test.go Outdated Show resolved Hide resolved
This makes the telemetry for the beta client aggregation easier to graph and use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants