Drop sampling rate when aggregation is enabled #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
force-pushed
the
maxime/drop-sampling-rate-aggregation
branch
2 times, most recently
from
1e50f7d
to
cf2d2a7
Compare
Mixing sampling rate and aggregation doesn't make sens and could be erroneous if users sends the same metrics with different sampling rate.
hush-hush
force-pushed
the
maxime/drop-sampling-rate-aggregation
branch
from
cf2d2a7
to
fa862cc
Compare
olivielpeau
approved these changes
Oct 22, 2020
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixing sampling rate and aggregation doesn't make sens and could be erroneous if users sends the same metrics with different sampling rate.