Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Total Requests should show the correct count when the skipFolders or skipRequests are used #419

Open
1 task done
gaumzi83 opened this issue Oct 29, 2023 · 10 comments
Labels
state: triaged This issue has been triaged type: enhancement New feature or request

Comments

@gaumzi83
Copy link

Is There An Existing Issue

What Are You Seeing

The following options are not working with reporter htmlextra:

skipFolders, skipRequests and displayProgressBar

Steps To Reproduce The Issue

Looking at htmlextra.js, the above options are not present. Could these be added please else there is no point having 'Skipped Tests' section in the html report if skipRequests option is not working.

Please could you fix this if possible.

Thanks

Full Newman Command Or Node Script

$ newman run collection.json –e environment.json –d datafile.csv –r cli,junit,htmlextra --reporter-htmlextra-skipRequests "send request"

HTMLEXTRA Version

1.22.11

Newman Version

6.0.0

Additional Context

No response

@gaumzi83 gaumzi83 added state: needs-triage This issue needs to be triaged type: bug Something isn't working labels Oct 29, 2023
@github-actions
Copy link

Hey @gaumzi83: 👋 - Thanks for helping to make the reporter better by raising this ticket. I will take a look as soon as I can and get back to you. Cheers, Danny.

@DannyDainton
Copy link
Owner

Hey @gaumzi83

Are you reporting that those flags are not working for you or that they are not part of htmlextra.js?

@DannyDainton DannyDainton added state: triaged This issue has been triaged state: awaiting-response Waiting the for the author to respond and removed state: needs-triage This issue needs to be triaged labels Oct 29, 2023
@gaumzi83
Copy link
Author

They are not working for me. So to investigate, I looked at htmlextra.js and they are not present in there.

@DannyDainton
Copy link
Owner

That file only drives the help menu on the CLI, it has nothing to do with the functionality of the reporter.

Can you provide more context/information about what's not working.

As you can imagine, saying it's not working doesn't really add much detail. 😅

@gaumzi83
Copy link
Author

By not working I mean, the reporter option "--reporter-htmlextra-skipRequests" is not skipping the request. I have provided the option with request name in following command and I expect the "send request" to be listed under the "Skipped Tests" section of the report but it is not. Instead, it is still listed under "Total Requests" section of the report.

$ newman run collection.json –e environment.json –d datafile.csv –r cli,junit,htmlextra --reporter-htmlextra-skipRequests "send request"

@DannyDainton
Copy link
Owner

That's not how that flag works:

An optional flag that will exclude specified requests, in the final report.

It will exclude that whole request and the data from the request, from the final report.

Skipped Requests have nothing to do with Skipped Tests. You can skip a test in a request using the pm.test.skip syntax in the Requests test section. That operation has nothing to do with the reporter.

@gaumzi83
Copy link
Author

ok understood. But then it should also not appear under "Total Requests" section of the report. isn't it?

@DannyDainton
Copy link
Owner

That's a different issue but the request did actually run so the numbers are correct but the consistency is off.

It's not something that I'm actively working on so the likelihood of that getting fixed in the near term is very low.

Please feel free to take a look and try and fix that if you like, all PRs are welcome.

@gaumzi83
Copy link
Author

I am new to this so I'll wait for your fix. Thank you :)

@DannyDainton DannyDainton added type: enhancement New feature or request and removed type: bug Something isn't working state: awaiting-response Waiting the for the author to respond labels Oct 31, 2023
@DannyDainton
Copy link
Owner

Just to be clear, you're going to be waiting a long time if you're waiting on me :D

@DannyDainton DannyDainton changed the title skipFolders, skipRequests and displayProgressBar options are not working [Feature Request] Total Requests should show the correct count when the skipFolders or skipRequests are used Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: triaged This issue has been triaged type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants