Skip to content

Chrome webview support #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2019

Conversation

kovacss
Copy link
Contributor

@kovacss kovacss commented May 3, 2019

Overview

@kovacss
Copy link
Contributor Author

kovacss commented May 3, 2019

I'm not quite sure what browser name would be best suited as this is only works on Android,
Maybe that android-chrome-webview or android-chromium-webview would be better ?

@DamonOehlman
Copy link
Owner

@kovacss Thanks for the PR. Ah naming... the age old problem. I don't think we need the android- prefix, but I do wonder if chromium-webview might be better. What do you think?

@kovacss
Copy link
Contributor Author

kovacss commented May 7, 2019

@DamonOehlman I think you're right, chromium-webview might be better. (PR Updated)

@DamonOehlman
Copy link
Owner

@kovacss cool - all looks good to me now. I'll merge it in and push a version update once #108 is approved and merge. Thanks for adding this in.

@DamonOehlman DamonOehlman merged commit fcb44d8 into DamonOehlman:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants