From 38d6b96ac86618d1c4ccdce56b6476b09862d085 Mon Sep 17 00:00:00 2001 From: kaustubh Date: Sun, 12 Apr 2020 19:01:57 +0530 Subject: [PATCH] Issue #7873: Resolve Pitest Issues - ImportOrderCheck (2) --- .ci/pitest.sh | 1 - .../tools/checkstyle/checks/imports/ImportOrderCheck.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.ci/pitest.sh b/.ci/pitest.sh index 333f01ccead..b07e901ad2b 100755 --- a/.ci/pitest.sh +++ b/.ci/pitest.sh @@ -73,7 +73,6 @@ pitest-imports) "IllegalImportCheck.java.html:
        if (!result) {
" "ImportControlLoader.java.html:
        else if (ALLOW_ELEMENT_NAME.equals(qName) || "disallow".equals(qName)) {
" "ImportOrderCheck.java.html:
                else if (matcher.start() == bestPos && matcher.end() > bestEnd) {
" - "ImportOrderCheck.java.html:
        final boolean separatorBetween = isStatic != lastImportStatic
" "ImportOrderCheck.java.html:
                if (!CommonUtil.endsWithChar(pkg, '.')) {
" "ImportOrderCheck.java.html:
        if (isStatic) {
" "ImportOrderCheck.java.html:
        return !beforeFirstImport && line - lastImportLine > 1;
" diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java index 13a5febcc65..4cc073c2d38 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java @@ -701,7 +701,7 @@ private boolean needSeparator(boolean isStatic) { staticImportSeparator = isStatic && separated; } final boolean separatorBetween = isStatic != lastImportStatic - && (separated || separatedStaticGroups) && staticImportsApart; + && (separated || separatedStaticGroups); return typeImportSeparator || staticImportSeparator || separatorBetween; }