Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Widget an interface and move it to it's own file #2295

Merged
merged 5 commits into from Oct 30, 2022
Merged

Make Widget an interface and move it to it's own file #2295

merged 5 commits into from Oct 30, 2022

Conversation

Almighty-Satan
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2294

Description

Moves Widget to it's own file.

Sanduhr32
Sanduhr32 reviewed Oct 22, 2022
View reviewed changes
Copy link
Contributor

@Sanduhr32 Sanduhr32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, i have these thoughts

src/main/java/net/dv8tion/jda/api/entities/Widget.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/Widget.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/Widget.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/Widget.java Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/Widget.java Outdated Show resolved Hide resolved
@MinnDevelopment MinnDevelopment added hacktoberfest-accepted type: breaking contains a backwards incompatible change labels Oct 22, 2022
@Almighty-Satan Almighty-Satan changed the title Move Widget class to it's own file Make Widget an interface and move it to it's own file Oct 23, 2022
DV8FromTheWorld
DV8FromTheWorld approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@DV8FromTheWorld DV8FromTheWorld merged commit 525faae into discord-jda:master Oct 30, 2022
@renovate renovate bot mentioned this pull request Jan 26, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanduhr32 Sanduhr32 Sanduhr32 left review comments

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted type: breaking contains a backwards incompatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Almighty-Satan @DV8FromTheWorld @Sanduhr32 @MinnDevelopment