Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slash command mentions #2251

Merged
merged 35 commits into from Oct 30, 2022
Merged

Add slash command mentions #2251

merged 35 commits into from Oct 30, 2022

Conversation

freya022
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Adds slash command mentions, as can be seen here

@freya022 freya022 marked this pull request as ready for review September 17, 2022 17:05
MinnDevelopment
MinnDevelopment requested changes Sep 17, 2022
View reviewed changes
src/main/java/net/dv8tion/jda/internal/interactions/command/CommandImpl.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/command/SlashCommandReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/command/SlashCommandReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/command/SlashCommandReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/ICommandReference.java Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/ICommandReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/ICommandReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/ICommandReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/Command.java Show resolved Hide resolved
@freya022 @Tais993
Apply suggestions from code review
6322ca2 
Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
@freya022 @DV8FromTheWorld
Update src/main/java/net/dv8tion/jda/api/entities/Message.java
9b069ea 
Co-authored-by: Austin Keener <keeneraustin@yahoo.com>
DV8FromTheWorld
DV8FromTheWorld approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a way to make a mention without having to build the entire command too probably.
But this is good enough for me for now 👍

@MinnDevelopment MinnDevelopment added the type: breaking contains a backwards incompatible change label Oct 23, 2022
@freya022 @MinnDevelopment
Apply suggestions from code review
769776e 
Co-authored-by: Florian Spieß <business@minn.dev>
@MinnDevelopment MinnDevelopment merged commit 32483a1 into discord-jda:master Oct 30, 2022
@freya022 freya022 deleted the feature/slash-mentions branch October 31, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tais993 Tais993 Tais993 left review comments

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

@MinnDevelopment MinnDevelopment MinnDevelopment approved these changes

Assignees
No one assigned
Labels
type: breaking contains a backwards incompatible change type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freya022 @DV8FromTheWorld @MinnDevelopment @Tais993