Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing wosPublisherContrib key-ref in wos-integration.xml (#9579) #9581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing wosPublisherContrib key-ref in wos-integration.xml (#9579) #9581

wants to merge 1 commit into from
+1 −0

Conversation

schastlivcev
Copy link

References

Description

Added missing wosPublisherContrib key-ref in wos-integration.xml file

Instructions for Reviewers

No specific instructions

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@schastlivcev schastlivcev mentioned this pull request May 15, 2024
Open
@schastlivcev
Copy link
Author

There are some problems with importing records from wos-response.xml in WOSImportMetadataSourceServiceIT tests, what should I do?

@tdonohue tdonohue added configuration Related to out-of-the-box configuration 1 APPROVAL pull request only requires a single approval to merge. tools: import-sources Related to "Live Import" Sources feature, allowing import of content via external APIs. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 15, 2024
@tdonohue
Copy link
Member

@schastlivcev : You would need to debug the errors in WOSImportMetadataSourceServiceIT. It's possible those errors are signs that this PR is not correct. But, it's also possible that the tests in WOSImportMetadataSourceServiceIT need to be fixed/updated.

You can run these same tests locally (to help debug the problem) as documented at https://github.com/DSpace/DSpace/tree/main?tab=readme-ov-file#running-tests

I won't be able to help investigate this further until likely after the 8.0 release. But, hopefully, that's enough information to help you get started.

@tdonohue tdonohue added the work in progress PR is still being worked on & is not currently ready for review label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schastlivcev schastlivcev

Labels
1 APPROVAL pull request only requires a single approval to merge. configuration Related to out-of-the-box configuration port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release tools: import-sources Related to "Live Import" Sources feature, allowing import of content via external APIs. work in progress PR is still being worked on & is not currently ready for review
Projects
DSpace 8.0 Release
Status: 🙋 Needs Reviewers Assigned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web of Science import missing entry key-ref wosPublisherContrib
2 participants
@schastlivcev @tdonohue