Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-instation HttpServletResponse reset in HttpHeadersInitializer upon Spring upgrade (to v5.2.9 or above) #3056

Open
jonas-atmire opened this issue Nov 19, 2020 · 2 comments
Open

Re-instation HttpServletResponse reset in HttpHeadersInitializer upon Spring upgrade (to v5.2.9 or above) #3056

jonas-atmire opened this issue Nov 19, 2020 · 2 comments
Labels
code task Code cleanup task dependencies Pull requests that update a dependency file Estimate TBD Needs to have an estimate added low priority

Comments

@jonas-atmire
Copy link
Contributor

jonas-atmire commented Nov 19, 2020 •
edited

The following is a placeholder issue ticket to make sure we do not lose track of the following todo

The method call in comments needs to be re-instated/investigated once spring has been upgraded to (at least) v5.2.9

For more information on this, please read through:
#3009
@jonas-atmire jonas-atmire mentioned this issue Nov 19, 2020
Merged
6 tasks
@tdonohue tdonohue changed the title Re-instation HttpServletResponse reset in HttpHeadersInitializer upon Spring upgrade Re-instation HttpServletResponse reset in HttpHeadersInitializer upon Spring upgrade (to v5.2.9 or above) Nov 20, 2020
@tdonohue tdonohue added code task Code cleanup task dependencies Pull requests that update a dependency file labels Nov 20, 2020
@tdonohue
Copy link
Member

tdonohue commented Nov 20, 2020 •
edited

Tentatively scheduling for 7.3, just because a Spring upgrade is not high priority right now. If priority changes, we may move this up.

@tdonohue tdonohue added this to To Do in DSpace 7.x Tier 2: Medium High Priority via automation Nov 20, 2020
@tdonohue tdonohue added this to the 7.2 milestone Nov 20, 2020
@tdonohue tdonohue added this to To Do in DSpace 7.x Tier 3: Medium Priority via automation Aug 4, 2021
@tdonohue tdonohue removed this from the 7.2 milestone Aug 4, 2021
@tdonohue tdonohue added the Estimate TBD Needs to have an estimate added label Aug 4, 2021
@tdonohue
Copy link
Member

tdonohue commented Mar 9, 2023

As of 7.5, we are now running Spring 5.3.20, so it would be possible to perform this change as needed. Unclear of the priority though as the reason this had to be removed in the first place is unclear.

Nonetheless, pulling onto 7.6 board to see if there is interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code task Code cleanup task dependencies Pull requests that update a dependency file Estimate TBD Needs to have an estimate added low priority
Projects
DSpace 8.0 Release
Status: 📋 To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdonohue @jonas-atmire