Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other guidance orgs checkboxes not removed when unchecked #3344

Open
StCyr opened this issue Sep 26, 2023 · 1 comment
Open

other guidance orgs checkboxes not removed when unchecked #3344

StCyr opened this issue Sep 26, 2023 · 1 comment

Comments

@StCyr
Copy link

StCyr commented Sep 26, 2023

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

4.1.0

Expected behaviour:

At step 6 in steps to reproduce hereunder, the unselected guidance, and all other guidances from the same organisation, should disappear from the "edit plan" page directly if it was the last selected guidance from this organisation. User shouldn't have to wait to reload the page for the list to be updated.

Actual behaviour:

See step 6 from steps to reproduce hereunder.

Here's a screenshot of the resulting guidance list after step 8 from "Steps to reproduce" hereunder:

image

Steps to reproduce:

  1. create a plan from a template with possible guidances
  2. click on "see the full list" in the "Select guidance" panel
  3. from the "Select guidance" modal window, select a guidance from an additional organisation
  4. confirm that the selected guidance (and all the other guidances from the same organisation) appears on the "edit plan" page behind the modal window
  5. unselect the guidance from the additional organisation
  6. confirm that the unselected guidance (and all other guidances from the same organisation) doesn't disappear from the "edit plan" page behind the modal window
  7. close the modal window
  8. confirm that the unselected guidance (and all other guidances from the same organisation) is still there in the "edit plan" page
  9. reload the page
  10. confirm that the unselected guidance (and all other guidances from the same organisation) has disappeared from the "edit plan" page
@nicolasfranck
Copy link
Contributor

What happens now: on selection of guidance groups in the modal, the short view is updated also.
But yes, the changes are not saved.

But then again, nothing is saved on this page until you hit the save button.

I remember that you guys added that second save button below
the guidance groups to make the behaviour more clear. Maybe
add that button also in the modal?

Unless you plan to fully remodel this page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants