New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Optimize aeskeygenassist_si128 in ARM64 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Dec 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine the subject of this pull request and git commit message. You shall emphasize the benefit with the proposed changes.
jserv
reviewed
Dec 27, 2022
jserv
reviewed
Dec 28, 2022
howjmay
force-pushed
the
opt_aeskeygenassist_si128
branch
from
December 28, 2022 07:46
1a3e100
to
dc53c0d
Compare
I found the previous implementation actually have used intrinsics. I will check the performance of my current implementation first, then reopen this PR. |
howjmay
force-pushed
the
opt_aeskeygenassist_si128
branch
from
December 28, 2022 09:56
dc53c0d
to
414aea9
Compare
howjmay
changed the title
refactor: Update aeskeygenassist_si128 to optimized ver
refactor: Optimize aeskeygenassist_si128 in ARM64
Dec 28, 2022
howjmay
force-pushed
the
opt_aeskeygenassist_si128
branch
from
December 28, 2022 10:38
414aea9
to
2b6659a
Compare
Conduct VTRN to remove bit selection operations.
howjmay
force-pushed
the
opt_aeskeygenassist_si128
branch
from
December 28, 2022 10:40
2b6659a
to
52c89e9
Compare
jserv
pushed a commit
that referenced
this pull request
Dec 28, 2022
Conduct VTRN to remove bit selection operations.
jserv
pushed a commit
that referenced
this pull request
Dec 28, 2022
Conduct VTRN to remove bit selection operations.
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conduct VTRN to remove bit selection operations.