Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimize aeskeygenassist_si128 in ARM64 #573

Merged
merged 1 commit into from Dec 28, 2022

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Dec 27, 2022

Conduct VTRN to remove bit selection operations.

Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refine the subject of this pull request and git commit message. You shall emphasize the benefit with the proposed changes.

sse2neon.h Outdated Show resolved Hide resolved
sse2neon.h Outdated Show resolved Hide resolved
@howjmay howjmay marked this pull request as draft December 28, 2022 07:48
@howjmay
Copy link
Contributor Author

howjmay commented Dec 28, 2022

I found the previous implementation actually have used intrinsics. I will check the performance of my current implementation first, then reopen this PR.

@howjmay howjmay changed the title refactor: Update aeskeygenassist_si128 to optimized ver refactor: Optimize aeskeygenassist_si128 in ARM64 Dec 28, 2022
Conduct VTRN to remove bit selection operations.
@howjmay howjmay marked this pull request as ready for review December 28, 2022 10:43
@howjmay howjmay requested a review from jserv December 28, 2022 12:46
@jserv jserv merged commit 9452ce1 into DLTcollab:master Dec 28, 2022
jserv pushed a commit that referenced this pull request Dec 28, 2022
Conduct VTRN to remove bit selection operations.
jserv pushed a commit that referenced this pull request Dec 28, 2022
Conduct VTRN to remove bit selection operations.
@howjmay howjmay deleted the opt_aeskeygenassist_si128 branch December 28, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants