feat: Implement _mm_undefined_pd #430
Merged
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you implement the corresponding test case? |
jserv
force-pushed
the
master
branch
3 times, most recently
from
eb8e6ef to
c902b5e
Compare
marktwtn
reviewed
Jun 11, 2021
tests/impl.cpp
Outdated
| @@ -6280,7 +6280,9 @@ result_t test_mm_ucomineq_sd(const SSE2NEONTestImpl &impl, uint32_t iter) | |||
|
|
|||
| result_t test_mm_undefined_pd(const SSE2NEONTestImpl &impl, uint32_t iter) | |||
| { | |||
| return TEST_UNIMPL; | |||
| __m128d a = _mm_undefined_pd(); | |||
| (void) a; | |||
There was a problem hiding this comment.
To remove the unused variable warning
There was a problem hiding this comment.
I guess we might just return TEST_SUCESS
or replace the code with _mm_undefined_pd() without declaring variable.
@jserv any suggestion?
There was a problem hiding this comment.
We can rewrite as following:
__m128d a = _mm_undefined_pd();
a = _mm_xor_pd(a, a);
return validateDouble(a, 0, 0);
marktwtn
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.