Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The launcher should not allow unpausing #3125

Open
uecasm opened this issue Mar 30, 2023 · 5 comments · May be fixed by DFHack/scripts#665
Open

The launcher should not allow unpausing #3125

uecasm opened this issue Mar 30, 2023 · 5 comments · May be fixed by DFHack/scripts#665

Comments

@uecasm
Copy link

uecasm commented Mar 30, 2023

Pressing the spacebar while typing a command in gui/launcher currently (as of 50.07-beta1 on Steam) unpauses/repauses. Since many DF commands require spaces, and the launcher is mostly-full-screen and there's not really any good reason to interact with the map while it's open (and many good reasons not to), this is bad.
@Cubittus
Copy link

Typing a space in the middle of a command does not unpause for me.
I only see this happen if the first character typed is a space. I find this useful on occasion as I may want to retain the launcher output text while watching something happen on the map. I run on a 1440p screen and size the launcher to only take up about 25% of the screen.

@myk002
Copy link
Member

myk002 commented Mar 30, 2023 •
edited

Yes, this is a feature, but a bug, since otherwise there is not a way to pause the game with the keyboard when you bring up gui/launcher and you have autopausing turned off in gui/control-panel.

Documented here: https://docs.dfhack.org/en/latest/docs/tools/gui/launcher.html#editing-and-running-commands

@myk002
Copy link
Member

myk002 commented Mar 30, 2023 •
edited

Is there something we could put on the screen that can make it more obvious that double-space (or single space on an empty line) pausing/unpausing is a thing?

@Cubittus
Copy link

How about:
Dwarf_Fortress-2023-03-30-150227-050

@uecasm
Copy link
Author

uecasm commented Mar 31, 2023 •
edited

Ok, it appears I must have been double-tapping space. I don't remember doing that yesterday, but I can't get it to happen today without doing that. Or maybe I just have a flaky keyboard?

Perhaps the hotkeys at the bottom could show space space: unpause? Though perhaps only if the DF hotkey hasn't been changed.

@Cubittus Cubittus linked a pull request Apr 2, 2023 that will close this issue
Open
@myk002 myk002 linked a pull request Apr 2, 2023 that will close this issue
launcher: add label showing pause status DFHack/scripts#665
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

launcher: add label showing pause status Cubittus/dfhack-scripts
3 participants
@uecasm @Cubittus @myk002