Allow plain ruby objects #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows non-ActiveModel/ActiveRecord objects to be used by the form builder, it's sometimes useful when working with transient data; an example would be searches. Fixes #88
To test the formbuilder components use against a plain ruby class.
This will highlight that there's a problem if a developer attempts to use the #govuk_error_summary in a form where the object doesn't respond to #errors. Also reformat and tidy up the examples file. The Naming/MethodParameterName cop is now disabled because it thinks two letter method params are bad (we're using :cv) 🤦
|
@jsugarman, would you mind giving this branch a spin and if it's all good I'll merge and get a mini release (with this and #89) prepped. Thanks |
peteryates
added a commit
that referenced
this pull request
Jan 9, 2020
Allow the form builder to work with plain ruby objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the form builder to operate with plain Ruby objects in addition to
ActiveModelandActiveRecordones that support#errors. This is useful when performing transient operations like searching.