Fix duplicate radio button hints #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike `govuk_collection_radio_buttons` this method does not pass the value to the hint and therefore doesn't generate a unique id for each hint element. Fix is simply to pass the value from FieldsetRadioButton to Hint.
3 tasks
Merged
peteryates
added a commit
that referenced
this pull request
Jan 9, 2020
Fix duplicate radio button hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a problem that was flagged in a usability/accessibility review of https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training. We have a couple of places where we use
govuk_radio_buttons_fieldsetandgovuk_radio_buttonwith thehint_textoption. The problem is that the hintspanelements end up with the sameidso they can't be linked to the correct radio button for accessibility purposes.This seems to be because
FieldsetRadioButtondoesn't pass it'svalueto it's childElements::Hint. Fix is simply to pass the value in the constructor.We found that
govuk_collection_radio_buttonsalready does this. It's not applicable in one of the cases for us because we use a divider within the radio button fieldset.