Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write class for KDE estimation #153

Open
paulmueller opened this issue Dec 1, 2021 · 1 comment
Open

Write class for KDE estimation #153

paulmueller opened this issue Dec 1, 2021 · 1 comment

Comments

@paulmueller
Copy link
Member

The current implementation of KDE computation (partly in rtdc_dataset.core) is not very clean. It would be best to have a new RTDCKDEEstimator class that can:

  • be instantiated with parameters such as kde_method="histogram"
  • uses the same KDE for scatter plot data as for contour data
  • this implies that for scatter plot data, the KDE is computed on a grid as well (and not for each point)
  • it would be nice to see timing information that compares a large and a small dataset with the methods implemented currently
  • there should be a method that refines the class parameters until the contour is smooth (no kinks, probably only applies to the histogram method)

This will be a breaking feature, so it would probably make sense to deprecate it properly in rtdc_dataset.core and dclab.kde_methods.

Related issues:

ZELLMECHANIK-DRESDEN/ShapeOut2#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant