Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No specific error raised when features required not available in plugin #150

Open
PinkShnack opened this issue Oct 29, 2021 · 4 comments
Open

Comments

@PinkShnack
Copy link
Contributor

When trying to access a plugin feature in a dataset that does not contain a features required feature, the only error raised is "Feature 'FEATURE_NAME' does not exist!" from dclab.rtdc_dataset.core.__getitem__. This is currently expected, but would it be reasonable to have a more specific exception?

@paulmueller
Copy link
Member

A verbose error message would have to name all the ancillary features that implement the feature and a message that states the user should check whether all conditions for that feature are met (e.g. print req_required, config_required, etc.). There are also custom functions a plugin feature may implement.

@PinkShnack
Copy link
Contributor Author

There are also custom functions a plugin feature may implement.

By this do you mean the "method check required" or some function that for example just checks that the correct features are available in the rtdc_ds?

If you mean the latter, when I tried, the plugin didn't raise the error I expected. I will recheck this and if the problem persists then I will paste the copy here...

@paulmueller
Copy link
Member

@PinkShnack
Copy link
Contributor Author

Perhaps we should add an example of this for plugin features in the docs and tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants