Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to show the Patient Identifier #3189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lomky
Copy link
Member

@lomky lomky commented Apr 18, 2024

I rule and have completed some work on Case Manager that's ready for review!

Added the option to show Daria's internal identifier as a nice shorthand ID, based on Fund request.

This pull request makes the following changes:

  • Adds the config
  • Adds the display field with a tooltip
  • Adds strings
Scenario Change
Show Patient Identifier image
Hover tooltip image
Config disabled image

It relates to the following issue #s:

For reviewer:

  • Adjust the title to explain what it does for the notification email to the listserv.
  • Tag this PR:
    • feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
    • dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.
  • If it contains neither, no need to tag this PR.

@lomky lomky changed the title Add config to show the Patient ID Add config to show the Patient Identifier Apr 18, 2024
@lomky lomky marked this pull request as ready for review April 18, 2024 00:37
@lomky lomky self-assigned this Apr 18, 2024
Copy link
Member

@colinxfleming colinxfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm! Possibly worth spot checking the system tests to see if this kinda thing is repped in there, but no concerns from my corner here. Fire when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config option to show a patient's daria identifier
2 participants