Add Practical Support Mode! #3050

elimbaum · 2023-08-25T17:48:54Z

I rule and have completed some work on Case Manager that's ready for review!

This pull request makes the following changes:

Adds a config for practical support mode (Add a Practical Support Mode config #2876) and marked_complete field in the Patient model.
Updates views when practical support mode is on; specifically, hides budget bar and fulfillment options, and changes language in table (Practical support: When mode on, don't display budget bar or fulfillment page #3017)
Changes the Submit Pledge button to Mark Complete, and updates the confirmation modals:

Currently, there is no valid for marking a patient complete, as there is for fulifilling a pledge; this could be changed.

DRAFT until tests are added.

It relates to the following issue #s:

Fixes Add a Practical Support Mode config #2876, Practical support: When mode on, don't display budget bar or fulfillment page #3017, Adjustments for practical support only funds? #2174, How to mark patients complete for a practical support fund? #2142

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:
- feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
- dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.
If it contains neither, no need to tag this PR.

colinxfleming

this is fabulous stuff, thank you @elimbaum ! Very clean effective rails and you've hit the vast majority of the spots where we'd need to do this. I think we'll also want to add this to exports and the accounting panel but both of those can be done in separate PRs if you think this one is too busy. I'll pull down and acid test more extensively once tests are in place if that's cool with you, let me know whether there's anything in particular you'd like my opinion on.

colinxfleming · 2023-08-26T19:15:35Z

app/models/config.rb

@@ -308,7 +315,7 @@ def validate_time_zone

    def validate_yes_or_no
      # allow yes or no, to be nice (technically only yes is considered)
-      options.last =~ /\A(yes|no)\z/i
+      validate_singleton and options.last =~ /\A(yes|no)\z/i


great rails

colinxfleming · 2023-08-26T19:16:14Z

app/models/config.rb

@@ -22,7 +22,8 @@ class Config < ApplicationRecord
    hide_budget_bar: 'Enter "yes" to hide the budget bar display.',
    aggregate_statistics: 'Enter "yes" to show aggregate statistics on the budget bar.',
    hide_standard_dropdown_values: 'Enter "yes" to hide standard dropdown values. Only custom options (specified on this page) will be used.',
-    time_zone: "Time zone to use for displaying dates. Default is Eastern. Valid options are Eastern, Central, Mountain, Pacific, Alaska, Hawaii, Arizona, Indiana (East), or Puerto Rico."
+    time_zone: "Time zone to use for displaying dates. Default is Eastern. Valid options are Eastern, Central, Mountain, Pacific, Alaska, Hawaii, Arizona, Indiana (East), or Puerto Rico.",
+    practical_support_mode: 'Enter "yes" to enable practical-support-only mode. Pledges will be disabled.'


Suggested change

practical_support_mode: 'Enter "yes" to enable practical-support-only mode. Pledges will be disabled.'

practical_support_mode: 'Enter "yes" to enable practical-support-only mode. Pledges will be disabled, in in favor of marking people complete/incomplete.'

app/views/dashboards/index.html.erb

elimbaum · 2023-08-28T20:29:25Z

Thanks for review @colinxfleming! am moving this week (and starting school...) but once I get a dev environment spun back up I'll close this out!

elimbaum · 2023-08-28T20:30:11Z

app/helpers/pledges_helper.rb

+  def mark_complete_button
+    content_tag :span, class: 'btn btn-primary btn-lg submit-btn btn-block',
+                       aria: { hidden: true },
+                       id: 'submit-pledge-button' do
+      t('patient.menu.mark_complete')
+    end 
+  end
+
+  def mark_incomplete_button
+    content_tag :span, class: 'btn btn-warning btn-lg cancel-btn btn-block',
+                       aria: { hidden: true },
+                       id: 'submit-pledge-button' do
+      t('patient.menu.mark_incomplete')
+    end 
+  end
+


These two functions look extremely similar to the submit pledge button pair (above). Thoughts on condensing, or fine to keep separate?

I'd say keep separate - reasonable for them to diverge a bit here

elimbaum · 2023-08-28T20:30:30Z

app/models/concerns/statusable.rb

-                help_text: I18n.t('patient.status.help.resolved')}
+                help_text: I18n.t('patient.status.help.resolved')},
+    completed: { key: I18n.t('patient.status.key.completed'),
+                 help_text: I18n.t('patient.status.help.completed') },


What do we use help_text for? I wasn't able to find a reference

These show up in the Status tooltip on patient records!

elimbaum · 2023-08-28T20:32:20Z

app/models/config.rb

+
+    def validate_only_one_practical_support
+      # TODO - Should not be able to use both practical support configs at the
+      # same time.
+      true
+    end


After this is done, I'm thinking about opening a separate issue to combine "practical support mode" and "hide practical supports" into a single option — practical supports only, on, off. in the interim, should we have some validation? Weird things will happen if we turn on both options.

How would that best work? We can't compare the actual saved values because on validation, the submitted value has not yet been committed. We could have a conditional check based on the option key?

Let me say a bit more about the thinking here, and let's see if that makes sense with how you're thinking about it. I think there are three possible states:

fund is not doing practical support at all (in which case we'd want to hide these options) - unusual but it happens

fund is doing pledges AND practical support - most of our clientele

fund is doing zero pledges, ONLY practical support - unusual but it happens

So I think you're def right that 'hide practical support on' and 'practical support only on' doesn't make sense, but I think the other cases (hide off, practical only on; hide on, practical only off; hide off, practical only off) are cases I think we'd like to support. Does that match your understanding?

elimbaum · 2023-08-28T20:33:05Z

app/views/patients/_complete.html.erb

what do you think about this modal? i don't know if we need any confirmation steps, so maybe we don't even need the modal - just the button?

I think yes to the modal -- an extra UX step to signify 'this is a significant action' is helpful (and helps prevent problems from misclicks)

elimbaum · 2023-08-28T20:33:34Z

app/views/patients/_menu_pledge_button.html.erb

+<% if Config.practical_support_mode? %>
+  <% if not patient.marked_complete? %>
+    <%= link_to mark_complete_button,
+                mark_complete_path(patient),
+                class: 'submit-pledge-button', # reuse classes from submit pledge button
+                aria: { label: t('patient.menu.mark_complete') },
+                remote: true %>
+  <% else %>
+    <%= link_to mark_incomplete_button,
+                mark_complete_path(patient),
+                class: 'submit-pledge-button',
+                aria: { label: t('patient.menu.mark_incomplete') },
+                remote: true %>
+  <% end %>
 <% else %>


same question here as with the button controller function - very similar code between in/complete and submit/cancel.

I think reasonable to collapse this one if you like. Up to you!

elimbaum · 2023-08-28T20:33:49Z

app/views/patients/complete.js.erb

ergh i hate this but is it ok?

this reads as ok to me, what's the issue?

elimbaum added 2 commits August 25, 2023 13:29

add practical support mode, draft; no tests

79a7bdc

add back validate stub

d5c748d

colinxfleming reviewed Aug 26, 2023

View reviewed changes

elimbaum commented Aug 28, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Practical Support Mode! #3050

Add Practical Support Mode! #3050

elimbaum commented Aug 25, 2023

colinxfleming left a comment

colinxfleming Aug 26, 2023

colinxfleming Aug 26, 2023

elimbaum commented Aug 28, 2023

elimbaum Aug 28, 2023

colinxfleming Sep 23, 2023

elimbaum Aug 28, 2023

colinxfleming Sep 23, 2023

elimbaum Aug 28, 2023

colinxfleming Sep 23, 2023

elimbaum Aug 28, 2023

colinxfleming Sep 23, 2023

elimbaum Aug 28, 2023

colinxfleming Sep 23, 2023

elimbaum Aug 28, 2023

colinxfleming Sep 23, 2023

	practical_support_mode: 'Enter "yes" to enable practical-support-only mode. Pledges will be disabled.'
	practical_support_mode: 'Enter "yes" to enable practical-support-only mode. Pledges will be disabled, in in favor of marking people complete/incomplete.'

Add Practical Support Mode! #3050

Are you sure you want to change the base?

Add Practical Support Mode! #3050

Conversation

elimbaum commented Aug 25, 2023

colinxfleming left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elimbaum commented Aug 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment