Autodeletion #2923
Draft
Autodeletion #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elimbaum
commented
Apr 14, 2023
Comment on lines
+18
to
+20
| def self.included(base) | ||
| base.extend(ClassMethods) | ||
| end |
There was a problem hiding this comment.
if this is to gnarly i can make a change ;)
elimbaum
commented
Apr 14, 2023
Comment on lines
+92
to
+108
| c.save! | ||
| end | ||
|
|
||
| it 'deletes pt_a on the right day' do | ||
| Timecop.freeze(1.day.ago) do | ||
| Patient.autodelete! | ||
| assert_includes Patient.all, @pt_a | ||
| end | ||
|
|
||
| # present day - doesn't delete because <, not <= | ||
| Patient.autodelete! | ||
| assert_includes Patient.all, @pt_a | ||
|
|
||
| Timecop.freeze(1.day.after) do | ||
| Patient.autodelete! | ||
| refute_includes Patient.all, @pt_a | ||
| end |
There was a problem hiding this comment.
ok this is a lil weird, because i'm using < with today, so it does a date-, not time-based comparison. I don't particularly have an issue with this -- I don't think funds will care exactly which day a patient deletes. but let me know and I can make it a bit more intuitive.
|
While this draft works, given our discussions yesterday, I think we should take a bit of time to consider exactly what we want this PR to do (and not do) |
|
@lomky let me know what you think of this — and particularly what other kinds of tests would help! have some time to work on things this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rule and have completed some work on Case Manager that's ready for review!
(brief, plain english overview of your changes here)
This pull request makes the following changes:
Timecopfor testing(If there are changes to the views, please include a screenshot so we know what to look for!)
It relates to the following issue #s:
For reviewer:
featureif it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.dependenciesif it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.