Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3 support (investigate) #22

Open
nicolechung opened this issue Oct 12, 2022 · 1 comment
Open

D3 support (investigate) #22

nicolechung opened this issue Oct 12, 2022 · 1 comment

Comments

@nicolechung
Copy link
Contributor

Mostly writing this as a reminder to myself (will try to open a branch to investigate this)

  1. We support SVGs in the code, but SVG doesn't (I think) have getBoundingClientRect. We should look into https://developer.mozilla.org/en-US/docs/Web/API/SVGGraphicsElement/getBBox.
  2. Some folks are using a Point object, which seems to have only an x,y and width value.

todos

  1. Update the tests to reflect working with svg elements and maybe points (will look into this) for this.hook
    https://github.com/CrowdStrike/ember-velcro/blob/main/test-app/tests/integration/components/velcro-test.js
@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Oct 12, 2022

for getBoundingClientRect, it looks like it is supported:
image

(I use this on my tool over here: NullVoxPopuli/baobab-ram#2 where SVG is used here: https://github.com/NullVoxPopuli/baobab-ram/pull/2/files#diff-3faf330991c5619676b7e34455f77bd5561d1c90638c2328bac9adc84ce83f1dR25 (the idFor) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants