Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared setuptools dependency #63

Open
FlotterCodername opened this issue Nov 6, 2023 · 0 comments · May be fixed by #64
Open

Undeclared setuptools dependency #63

FlotterCodername opened this issue Nov 6, 2023 · 0 comments · May be fixed by #64

Comments

@FlotterCodername
Copy link

FlotterCodername commented Nov 6, 2023

This package currently uses pkg_resources module from setuptools package:

from pkg_resources import get_distribution

__version__ = get_distribution("m2r2").version

This is not part of the standard library and thus must be declared in setup.py.
As an example, if you are using the Poetry build system, you will not have setuptools by default.
In this case, your doc build will crash in a way that is in my experience hard to understand for lots of users.
Recommended to set lower bounds for the package only, if at all to avoid breaking other people's stuff.

FlotterCodername added a commit to FlotterCodername/m2r2 that referenced this issue Nov 6, 2023
@FlotterCodername FlotterCodername linked a pull request Nov 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant