This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
cranelift-wasm hooks to instrument wasm operators #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iximeow
commented
Jul 22, 2019
| @@ -206,7 +206,9 @@ fn parse_function_body<FE: FuncEnvironment + ?Sized>( | |||
| while !state.control_stack.is_empty() { | |||
| builder.set_srcloc(cur_srcloc(&reader)); | |||
| let op = reader.read_operator()?; | |||
| translate_operator(op, builder, state, environ)?; | |||
| environ.before_translate_operator(&op, builder)?; | |||
| translate_operator(&op, builder, state, environ)?; | |||
There was a problem hiding this comment.
op being used in {before,after}_translate_operator is what necessitates the bulk of this PR, by changing to &op here.
iximeow
commented
Jul 22, 2019
| @@ -130,8 +130,13 @@ impl ControlStackFrame { | |||
| /// - The depth of the two unreachable control blocks stacks, that are manipulated when translating | |||
| /// unreachable code; | |||
| pub struct TranslationState { | |||
| /// A stack of values corresponding to the active values in the input wasm function at this | |||
There was a problem hiding this comment.
I was initially thinking we'd want to expose the function's corresponding TranslationState (in case a user of cranelift-wasm wanted to add/modify values or the control stack), but that ended up not being necessary in how I'm using this right now. #[deny(missing_docs)] got me to fill in docs here and I figure they don't hurt to keep around :)
It seems like tweaking TranslationState would be a very typical {before,after}_translate_operator use case, so passing along TranslationState might make sense even if not strictly necessary in my use right now
pchickey
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances we'd like to insert instructions, and update translator-internal state, based on the wasm operations being translated. This adds a pair of functions to
FuncEnvironmentto support that (and adjustsfunc_translatorto call them appropriately)