feature/add-catch-all-route #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohuynh
requested changes
May 25, 2022
There was a problem hiding this comment.
Looks good. I have few minor asks for the styling.
Just a heads up regarding git history. Your local main should contain only peer-reviewed code. Meaning you shouldn't merge local changes to your local main branch. Instead, you can get the latest changes from upstream (this repo)'s main branch if you need to resolve a merge conflict. This way you can keep the commit history of the PR clean (e.g. it wouldn't include your Underline commit in this PR).
Edit:
Or maybe you created a new branch(enhancement/addcatchallroute) based off your "Underline" branch instead of the main branch.
|
Great suggestions To. Neel, super pleased to see your work 👍 |
BrianL3
approved these changes
May 25, 2022
evamaxfield
reviewed
May 26, 2022
tohuynh
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #102
Description of Changes
Displays an error message when the route given is not provided. Also provides a general error page for future development.
Link to Site
https://neelapte.github.io/cdp-frontend/#/9999
This page displays a page not found error.
https://neelapte.github.io/cdp-frontend/#/events/8888
This page displays a formatted error.
Please see
CONTRIBUTING.mdfor directions on how this can be done.