fix/person-roles #224
Merged
fix/person-roles #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evamaxfield
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #
Description of Changes
Include a description of the proposed changes.
In light of CouncilDataProject/cdp-scrapers#73 and that only a Councilmember role signify that person has been elected for a term (and the start and end date of the role are the start and end date of the term), modify the method to fetch Councilmember roles (remove council president from the where clause) and the method to partition Councilmember roles and non-councilmember roles.
Also, localize Supervisor role using Google translate 馃し
Link to Forked Storybook Site
If component changes (especially visual changes) are contained in this PR, we ask that you provide a link to a publicly viewable version of the Storybook docs site, so PR reviewers can see your changes without having to install and view your code locally.
Please see
CONTRIBUTING.mdfor directions on how this can be done.