Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/infra-stack #202

Merged
merged 16 commits into from Aug 17, 2022
Merged

bugfix/infra-stack #202

merged 16 commits into from Aug 17, 2022

Conversation

evamaxfield
Copy link
Member

Almost complete fix for infra stack failing to deploy.

The current issue as a reminder is that Pulumi is losing track of the index creation job IDs.

After a bit of time debugging Pulumi, I figured I should try with just bare bones CLI tools and no fancy Pulumi or anything. Turns out it works better than before.

  1. Removes Pulumi entirely in favor of setting up infrastructure with gcloud, firebase cli, and gsutil. This means no Pulumi account will be required anymore.
  2. This adds the security rules creation directly to the process and CORS setup.
  3. Indexes and metadata doc are handling in Python with minimal scripts.
  4. It's way faster.

Left todo: determine the best method for mirror this in the cookiecutter and testing out a full deployment.

@evamaxfield evamaxfield added bug Something isn't working enhancement New feature or request labels Aug 16, 2022
@evamaxfield evamaxfield self-assigned this Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #202 (3e151fe) into main (2095b24) will decrease coverage by 2.50%.
The diff coverage is 11.53%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   74.82%   72.32%   -2.51%     
==========================================
  Files          66       65       -1     
  Lines        3381     3404      +23     
==========================================
- Hits         2530     2462      -68     
- Misses        851      942      +91     
Impacted Files Coverage Δ
cdp_backend/bin/get_cdp_infrastructure_stack.py 0.00% <0.00%> (ø)
cdp_backend/bin/store_cdp_metadata_document.py 0.00% <0.00%> (ø)
cdp_backend/database/models.py 100.00% <ø> (ø)
cdp_backend/infrastructure/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
cdp_backend/database/types.py 100.00% <100.00%> (ø)
cdp_backend/tests/database/test_models.py 96.96% <100.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant