Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/upgrade-packaging-standards #201

Merged
merged 6 commits into from Aug 14, 2022
Merged

Conversation

evamaxfield
Copy link
Member

@evamaxfield evamaxfield commented Aug 14, 2022

Uses https://github.com/evamaxfield/cookiecutter-py-package as new base cookiecutter and upgrades repo and python packaging standards.

Also removes a lot of files and interestingly, I tried removing all the type errors and everything worked (with two exceptions, @dataclass_json calls have moved to DataClassJsonMixin object inheritance and I swapped max(... key=) call with a standard "find max" for loop)

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #201 (80c78cd) into main (48a9adb) will decrease coverage by 0.29%.
The diff coverage is 82.25%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   91.20%   90.90%   -0.30%     
==========================================
  Files          53       53              
  Lines        2751     2739      -12     
==========================================
- Hits         2509     2490      -19     
- Misses        242      249       +7     
Impacted Files Coverage Δ
cdp_backend/annotation/speaker_labels.py 0.00% <0.00%> (ø)
cdp_backend/__init__.py 75.00% <75.00%> (-25.00%) ⬇️
cdp_backend/database/functions.py 90.82% <80.00%> (-0.40%) ⬇️
cdp_backend/pipeline/event_gather_pipeline.py 86.00% <80.00%> (ø)
..._backend/pipeline/generate_event_index_pipeline.py 97.29% <100.00%> (-0.04%) ⬇️
cdp_backend/pipeline/ingestion_models.py 100.00% <100.00%> (ø)
cdp_backend/pipeline/pipeline_config.py 100.00% <100.00%> (ø)
cdp_backend/pipeline/transcript_model.py 85.18% <100.00%> (-1.71%) ⬇️
...ckend/tests/pipeline/test_event_gather_pipeline.py 100.00% <100.00%> (ø)
...ackend/tests/pipeline/test_event_index_pipeline.py 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evamaxfield evamaxfield merged commit 2095b24 into main Aug 14, 2022
@evamaxfield evamaxfield deleted the admin/upgrade-package-standards branch August 14, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant