Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/support-undownloadable-vimeo-links #205

Merged

Conversation

sagarrat7
Copy link
Contributor

Link to Relevant Issue

This pull request resolves #191

Description of Changes

Use Vimeo.from_video_id() instead of Vimeo() when downloading from Vimeo. This supports downloading from URLs with the form: https://vimeo.com/showcase/6277394/video/722690793, as well as the previously supported form: https://vimeo.com/686512896.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #205 (945b27c) into main (1e5b807) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   72.29%   72.50%   +0.20%     
==========================================
  Files          64       64              
  Lines        3404     3415      +11     
==========================================
+ Hits         2461     2476      +15     
+ Misses        943      939       -4     
Impacted Files Coverage Δ
cdp_backend/tests/conftest.py 100.00% <100.00%> (ø)
cdp_backend/tests/utils/test_file_utils.py 100.00% <100.00%> (ø)
cdp_backend/utils/file_utils.py 94.82% <100.00%> (+2.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow really nice work and quick find!

Only have one comment which is to make sure a result was found so that we can have a better error message in the case we didn't find anything.

cdp_backend/utils/file_utils.py Show resolved Hide resolved
@evamaxfield evamaxfield merged commit 8292c7a into CouncilDataProject:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process vimeo video URLs
2 participants