Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cw20-base to use controller pattern #205

Closed
4 tasks
ethanfrey opened this issue Dec 21, 2020 · 1 comment
Closed
4 tasks

Refactor cw20-base to use controller pattern #205

ethanfrey opened this issue Dec 21, 2020 · 1 comment

Comments

@ethanfrey
Copy link
Member

This should be an easier and more extensible way to extend it than the current function dispatching.

So we can call the handle_X and query_X functions, or the lower-level functionality of the controller if we need to customize more.

  • Allowances
  • Balances

When done, update

  • cw20-staking
  • cw20-bonding

to make use of them. This should be easier to override and customize. Note the "sub dispatches" to handle_burn, which is a kind of ugly. It is nice to have a slightly lower-level function exposed to be imported by other handle functions if they want to customize.

@ethanfrey ethanfrey added this to To do in Contract development via automation Dec 21, 2020
@ethanfrey ethanfrey added this to the 0.6.0 milestone Feb 26, 2021
@ethanfrey ethanfrey moved this from To do to In progress in Contract development Mar 3, 2021
@ethanfrey ethanfrey moved this from In progress to To do in Contract development Mar 3, 2021
@ethanfrey ethanfrey removed this from the 0.6.0 milestone Mar 3, 2021
@ethanfrey
Copy link
Member Author

This is an old idea, made obsolete by #391 which is much more developed idea along similar lines

Contract development automation moved this from To do to Done Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant