Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second attempt to cosmwasm-core #2136

Open
webmaster128 opened this issue May 8, 2024 · 0 comments
Open

Second attempt to cosmwasm-core #2136

webmaster128 opened this issue May 8, 2024 · 0 comments
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented May 8, 2024

Right now on main, the existence cosmwasm-core creates all sorts of indirections an undesired dependencies that we want to avoid. So let's revert the current approach.

A new attempt to pull out cosmwasm-core that we may or may not do should have the following properties

  • does not depend on cosmwasm-crypto (not at runtime, not as dev-dependency)
  • does not pull in the StdError type

One way to do that is to ensure the error types for the relevant symbols are not StdError.

  • Avoid renaming symbols whenever possible (StdError/CoreError causes confusion)
  • from_base64 can get it's own InvalidBase64Error
  • HexBinary can get its own InvalidDataSizeError
  • For the integer and decimal types create a dedicated error type for the impl TryFrom<&str>, all the other errors are already specialized
  • ...

Those new errors can then be converted to StdError in cosmwasm-std.

@webmaster128 webmaster128 added this to the 3.0.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant