Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Wasmer to Version 3 #1469

Closed
3 tasks
webmaster128 opened this issue Oct 24, 2022 · 2 comments
Closed
3 tasks

Upgrade Wasmer to Version 3 #1469

webmaster128 opened this issue Oct 24, 2022 · 2 comments
Labels
wasmer3/4 Changes related to the upgrade to Wasmer 3 and 4
Milestone

Comments

@webmaster128
Copy link
Member

Upgrading to Wasmer 3 is important to keep in sync with the upstream development. The following changes have been highlighted by the team:

  1. We solved a lot of side effects that were indirectly causing memory leaks in some edge cases
  2. It increases performance of Wasmer (since wasmer::deserialize should be now zero-copy)
  3. It improves greatly the API to be more resilient long-term

One thing I noticed during the integration work was that we can now copy byte arrays in and out utilizing WasmSlice and don't have to loop over bytes anymore.

In #1438 and #1467 the integration work was started.

Before we can finalize and merge this, we need the following issues to be solved:

Bonus issues to track which are important are not blocking

@ethanfrey
Copy link
Member

Happy to add to next release if wasmer is ready by then.
Otherwise, just keep on ice til wasmer issues resolved

@webmaster128 webmaster128 modified the milestones: 1.2.0, 1.3.0 Nov 29, 2022
@webmaster128
Copy link
Member Author

Done in #1674

@webmaster128 webmaster128 mentioned this issue May 24, 2023
3 tasks
@webmaster128 webmaster128 added the wasmer3/4 Changes related to the upgrade to Wasmer 3 and 4 label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmer3/4 Changes related to the upgrade to Wasmer 3 and 4
Projects
None yet
Development

No branches or pull requests

2 participants