Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google java format to 1.15.0 #86

Closed
valeriuvancea opened this issue May 20, 2022 · 4 comments · Fixed by #87
Closed

Update google java format to 1.15.0 #86

valeriuvancea opened this issue May 20, 2022 · 4 comments · Fixed by #87

Comments

@valeriuvancea
Copy link

It would be nice to update the google java format version to 1.15.0, so there will be no need for the --add-exports

@duke1995
Copy link
Contributor

duke1995 commented May 26, 2022

@reda-alaoui

FYI: According to this comment on the google-java-format GitHub site, the --add-exports flags are no longer needed when invoking the CLI using java -jar, but they are still needed when using google-java-format as a library (which is the case for this plugin): Java 17 compatibility · Issue #612 · google/google-java-format

I don't use Java 17, so I haven't been able to verify this issue myself.

@reda-alaoui
Copy link
Member

reda-alaoui commented May 26, 2022

Thanks for letting me know. The documentation change has to be reverted in this case.

@duke1995
Copy link
Contributor

@reda-alaoui

I did a test to be sure and documented the results here. In summary, it will be best to revert the documentation change for the time being, as you suggested above.

@reda-alaoui
Copy link
Member

Fixed in ca389eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants