Adding dotnet 6 target #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Jan 5, 2022
| @@ -145,7 +145,7 @@ public void CanOpenEnvironmentMoreThan50Mb() | |||
| } | |||
|
|
|||
|
|
|||
| #if (NETCOREAPP3_1 || NET5_0) | |||
| #if NETCOREAPP3_1 || NET5_0 || NET6_0 | |||
There was a problem hiding this comment.
#if NETCOREAPP3_1_OR_GREATER
Though I am confused since these are the only targets, so maybe unnecessary?
| @@ -4,7 +4,7 @@ | |||
| <Description>LightningDB</Description> | |||
| <VersionPrefix>0.14.0</VersionPrefix> | |||
| <Authors>Ilya Lukyanov;Corey Kaylor</Authors> | |||
| <TargetFrameworks>netstandard2.0;netcoreapp3.1;net5.0</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;netcoreapp3.1;net5.0;net6.0</TargetFrameworks> | |||
There was a problem hiding this comment.
There is no reason to add a target. For instance netstandard2.0 covers net6.0.
Unless ... you are updating dependency, or a direct dependency targets it too.
Note: Here you can remove the dependency on System.Memory for netcoreapp31 and greater.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.