Fix async command event notifications #122
Merged
+127
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
improvements ✨
Sergio0694
force-pushed
the
dev/async-command-events-fixup
branch
from
9884277 to
d96f560
Compare
Arlodotexe
approved these changes
Feb 28, 2022
Sergio0694
force-pushed
the
dev/async-command-events-fixup
branch
from
d96f560 to
ab3e9f0
Compare
Sergio0694
force-pushed
the
dev/async-command-events-fixup
branch
from
ab3e9f0 to
c9f5b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few tweaks to async commands:
IAsyncRelayCommand.CanBeCanceled.IAsyncRelayCommand.Cancel()now only raises events if it actually cancels an operation.IAsyncRelayCommand.CanBeCanceledremainingfalseafter canceling.