Test Failed

[cam2904]

Hello.
I was checking the tests trying to understand CSS and had the test/integration/Identity.test.ts test fail. Can someone explain it please?

it('consents and redirects back to the client.', async(): Promise<void> => {
  let res = await state.fetchIdp(controls.oidc.consent);
  const json = await res.json();
  expect(json.webId).toBe(webId);
  expect(json.client.grant_types).toContain('authorization_code');
  expect(json.client.grant_types).toContain('refresh_token');

  res = await state.fetchIdp(controls.oidc.consent, 'POST');

  // Redirect back to the client and verify login success
  await state.handleIncomingRedirect(res, webId);
});

[TallTed]

@cam2904 — To improve clarity, I suggest you add codefences around the code in your post. A line of three backticks (```) and nothing else, above and below the code, will do the job.

[joachimvh]

(I have edited the message to add backticks for readability).

If you have changed nothing to the server/tests there should be no reason for these to fail. These are run automatically by the CI in this repository and they pass there. Unless you have a very specific setup that would impact this.

[cam2904]

I did not make any changes but to make sure that the issue is not caused by my setup, I have downloaded the CSS and ran the test in another computer without making any changes and it still failed.
What I am trying to do it to find a way to add the iss (the issuer identity) attribute to the authorisation code sent by the IdP to the app during the authorisation flow and test it. Please do let me know if you have any suggestions to the matter.
Thank you.

[joachimvh]

I can't explain why the tests are not working on your system. Where is the test failing with what error?

The IDP already returns the issuer in several places during the authorisation flow though. It is a query parameter when calling the callback URL of the client, and it is also a field in the returned token.