Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow supressing debugCookies() #110

Closed
lolli42 opened this issue Oct 4, 2022 · 2 comments · Fixed by #111
Closed

Allow supressing debugCookies() #110

lolli42 opened this issue Oct 4, 2022 · 2 comments · Fixed by #111

Comments

@lolli42
Copy link
Contributor

lolli42 commented Oct 4, 2022

Method WebDriver->setCookie() has an argument to suppress debugCookies().

Methods seeCookie(), dontSeeCookie(), resetCookie() and loadSessionSnapshot() don't provide this.

We're using a helper to set cookies for quick access of our login restricted things and the cookie output is kinda noisy, which we'd like to suppress.

I could come up with a quite simple PR to add this. Do you think this would find general acceptance?
@Naktibalda
Copy link
Member

setCookie parameter was added in Codeception/Codeception#5709 to fix a similar issue with loadSessionSnapshot.

Adding $showDebug parameter to all cookie methods is a bit ugly, but I don't have any better ideas, so please raise the pull request.

lolli42 added a commit to lolli42/module-webdriver that referenced this issue Oct 8, 2022
@lolli42
[TASK] Optionally suppress cookie debug output
97a7686 
Similar to WebDriver->setCookie(), methods seeCookie(),
dontSeeCookie(), resetCookie() and loadSessionSnapshot()
have an additional optional argument to suppress debug
output of cookie operations.

Closes: Codeception#110
@lolli42 lolli42 mentioned this issue Oct 8, 2022
Merged
@lolli42
Copy link
Contributor Author

lolli42 commented Oct 17, 2022

Cool thing. Happy thanks!

lolli42 added a commit to TYPO3/testing-framework that referenced this issue Oct 26, 2022
@lolli42
[TASK] Use acceptance test loadSessionSnapshot without debug
34824d9 
Not debugging reset cookies reduces noise
running acceptance tests. This has been added
with codeception 3.2.0.

Codeception/module-webdriver#111
Codeception/module-webdriver#110
lolli42 added a commit to TYPO3/testing-framework that referenced this issue Oct 26, 2022
@lolli42
[TASK] Use acceptance test loadSessionSnapshot without debug
a312e75 
Not debugging reset cookies reduces noise
running acceptance tests. This has been added
with codeception/module-webdriver 3.2.0.

Codeception/module-webdriver#111
Codeception/module-webdriver#110
lolli42 added a commit to TYPO3/testing-framework that referenced this issue Oct 26, 2022
@lolli42
[TASK] Use acceptance test loadSessionSnapshot without debug
760a498 
Not debugging reset cookies reduces noise
running acceptance tests. This has been added
with codeception/module-webdriver 3.2.0.

Codeception/module-webdriver#111
Codeception/module-webdriver#110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK] Optionally suppress cookie debug output lolli42/module-webdriver
2 participants
@Naktibalda @lolli42