Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createScreenshot() does not take into account window.devicePixelRatio #62

Open
mklepaczewski opened this issue Dec 23, 2019 · 1 comment
Open

createScreenshot() does not take into account window.devicePixelRatio #62

mklepaczewski opened this issue Dec 23, 2019 · 1 comment

Comments

@mklepaczewski
Copy link

mklepaczewski commented Dec 23, 2019 •
edited

VisualCeption::createScreenshot() doesn't take into account window.devicePixelRatio and incorrectly calculates $coords, in particular when the screenshot is limited to a specific element.
@mklepaczewski mklepaczewski changed the title createScreenshot() does not take into account window.window.devicePixelRatio createScreenshot() does not take into account window.devicePixelRatio Dec 23, 2019
@AdamOakman
Copy link

I can confirm there is indeed a problem in taking pictures for pixel ratio other than 1 - is there any chance for fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mklepaczewski @AdamOakman