Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis support through @template #24

Closed
ostrolucky opened this issue Jun 21, 2020 · 3 comments · Fixed by #25
Closed

Static analysis support through @template #24

ostrolucky opened this issue Jun 21, 2020 · 3 comments · Fixed by #25

Comments

@ostrolucky
Copy link
Contributor

Phpunit mocks have support for SA tools like Psalm/PHPStan since last year, thanks to sebastianbergmann/phpunit#3708. Codeception mocks, however don't. I might contribute this. Is this something you would welcome?
@ostrolucky
Copy link
Contributor Author

@Naktibalda can I contribute this?

@Naktibalda
Copy link
Member

Do you mean @psalm-template ExpectedType comments?
Seems fine to me, please raise the pull request.

@ostrolucky ostrolucky mentioned this issue Jun 28, 2020
Merged
@ostrolucky
Copy link
Contributor Author

Done! Please see #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make stubs more SA-friendly via @template
2 participants
@Naktibalda @ostrolucky