New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code quality, fix bug, added chained methods, added new BDD methods. #51
Conversation
So many changes, I will try to understand what was changed another day. |
they are in fact less than they appear to be.
If you need more help reviewing the changes, please let me know, I'll be as explicit as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me, except naming things 😁
If you want to improve specify I would be glad to give all my support with it. As long as tests pass feel free to improve it.
Btw, please join Codeception Slack channel so we could discuss big changes like this upfront. When you are there - text me privately.
src/Codeception/Specify.php
Outdated
return $params['examples']; | ||
} | ||
return [[]]; | ||
use SpecifyBoostrap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrap maybe?
use ReflectionProperty; | ||
use RuntimeException; | ||
|
||
trait SpecifyBoostrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrap?
src/Codeception/Specify.php
Outdated
return $params['examples']; | ||
} | ||
return [[]]; | ||
use SpecifyBoostrap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this naming:
SpecifyHooks
Before and After are hooks, we can name it like this
fixes #48 .
Code Quality:
Specify.php
, and private properties and methods insideSpecify\SpecifyBoostrap.php
for clarity and readability.Once and for all:
specify()
anddescribe()
blocks pass tests #48 ).Good things, even better:
it
's andshould
's chained to aspecify
ordescribe
. In this way, this example code:can now be written like this:
Specify is smarter:
its
forit
, and addedshouldNot
as counterpart ofshould
.phpunit.result.cache
file to.gitignore
Getting started:
Codeception/Specify
folder.@DavertMik , @Naktibalda I'll pay attention to your comments.