From d1d5134be7fc6b6a0c4d2b1562ac512f430c8559 Mon Sep 17 00:00:00 2001 From: Marco van 't Wout Date: Wed, 19 May 2021 16:30:02 +0200 Subject: [PATCH 1/2] Don't attempt to set cookie domain when it is "localhost" See https://stackoverflow.com/questions/1134290/cookies-on-localhost-with-explicit-domain --- src/Codeception/Coverage/Subscriber/LocalServer.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Codeception/Coverage/Subscriber/LocalServer.php b/src/Codeception/Coverage/Subscriber/LocalServer.php index 259d655a8b..bd29855004 100644 --- a/src/Codeception/Coverage/Subscriber/LocalServer.php +++ b/src/Codeception/Coverage/Subscriber/LocalServer.php @@ -201,6 +201,13 @@ protected function startCoverageCollection($testName) // we need to separate coverage cookies by host; we can't separate cookies by port. $cookieDomain = isset($c3Url['host']) ? $c3Url['host'] : 'localhost'; } + + $cookieParams = []; + if ($cookieDomain !== 'localhost') { + $cookieParams['domain'] = $cookieDomain; + } + + $this->module->setCookie(self::COVERAGE_COOKIE, $value, $cookieParams); $this->module->setCookie(self::COVERAGE_COOKIE, $value, ['domain' => $cookieDomain]); From 0ec65454b7b7062cf5e45a7c4589594e3f5ea2e1 Mon Sep 17 00:00:00 2001 From: Marco van 't Wout Date: Thu, 20 May 2021 10:30:10 +0200 Subject: [PATCH 2/2] Remove accidental leftover line --- src/Codeception/Coverage/Subscriber/LocalServer.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Codeception/Coverage/Subscriber/LocalServer.php b/src/Codeception/Coverage/Subscriber/LocalServer.php index bd29855004..86e9bc33e3 100644 --- a/src/Codeception/Coverage/Subscriber/LocalServer.php +++ b/src/Codeception/Coverage/Subscriber/LocalServer.php @@ -209,8 +209,6 @@ protected function startCoverageCollection($testName) $this->module->setCookie(self::COVERAGE_COOKIE, $value, $cookieParams); - $this->module->setCookie(self::COVERAGE_COOKIE, $value, ['domain' => $cookieDomain]); - // putting in configuration ensures the cookie is used for all sessions of a MultiSession test $cookies = $this->module->_getConfig('cookies');