From 6c77c92ac0626e8dfff00e4bbadbd5f07acc5951 Mon Sep 17 00:00:00 2001 From: JvE Date: Tue, 16 Apr 2019 11:29:52 +0200 Subject: [PATCH] Avoid removing required fields in cookies. --- src/Codeception/Module/WebDriver.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Codeception/Module/WebDriver.php b/src/Codeception/Module/WebDriver.php index e8c516bb74..121be5368e 100644 --- a/src/Codeception/Module/WebDriver.php +++ b/src/Codeception/Module/WebDriver.php @@ -825,13 +825,17 @@ public function setCookie($cookie, $value, array $params = []) } } // #5401 Supply defaults, otherwise chromedriver 2.46 complains. - $params = array_filter($params); - $params += [ + $defaults = [ 'path' => '/', 'expiry' => time() + 86400, 'secure' => false, 'httpOnly' => false, ]; + foreach ($defaults as $key => $default) { + if (empty($params[$key])) { + $params[$key] = $default; + } + } $this->webDriver->manage()->addCookie($params); $this->debugSection('Cookies', json_encode($this->webDriver->manage()->getCookies())); }