Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tryTo methods must always return Boolean result #6614

Merged
merged 1 commit into from Dec 17, 2022
Merged

tryTo methods must always return Boolean result #6614

merged 1 commit into from Dec 17, 2022

Conversation

Naktibalda
Copy link
Member

Fixes #6559

@Arhell Arhell requested a review from DavertMik December 9, 2022 00:11
jmrieger
jmrieger approved these changes Dec 12, 2022
View reviewed changes
Copy link

@jmrieger jmrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running into this same issue when updating to Codeception 5. The proposed changes definitely look like they will solve the attached issue, and I also appreciate including the logical check for this in tests.

@Naktibalda Naktibalda merged commit 7bee938 into 5.0 Dec 17, 2022
@Naktibalda Naktibalda deleted the try-to-methods-always-return-bool branch December 17, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrieger jmrieger jmrieger approved these changes

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The generated TryTo* function does not have a return statement
3 participants
@Naktibalda @jmrieger @Arhell